Wires up transients for DesktopWindowTreeHostMus

Wires up transients for DesktopWindowTreeHostMus

This code is a copy of that in DesktopWindowTreeHostX11.

BUG=660994
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/7cb222342ba74dc2241930b02739c10861d51dfe
Cr-Commit-Position: refs/heads/master@{#430090}

[sky, 2016-11-04 23:07:28]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 23:07:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-11-04 23:21:44]

lgtm with super nitty nits.

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
File ui/views/mus/desktop_window_tree_host_mus.cc (right):

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
ui/views/mus/desktop_window_tree_host_mus.cc:51: DCHECK(parent_);
nit: seems unnecessary to DCHECK a non-null value that's just been
static-casted, and is about to be dereferenced, but I'll leave it up to you.

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
ui/views/mus/desktop_window_tree_host_mus.cc:83: for (DesktopWindowTreeHostMus*
child : children_copy)
totally optional nit: convert the corresponding DesktopWindowTreeHostX11 code to
better match this (member names, for-range loop, comments, etc.) or vice versa.

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
ui/views/mus/desktop_window_tree_host_mus.cc:92:
native_widget_delegate_->OnNativeWidgetDestroying();
q: DesktopWindowTreeHostX11 orders this before child/parent destruction, is
there a reason they should differ?

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
File ui/views/mus/desktop_window_tree_host_mus.h (right):

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
ui/views/mus/desktop_window_tree_host_mus.h:8: #include <memory>
nit: #include <set>

[sky, 2016-11-04 23:30:43]

The CQ bit was checked by sky@chromium.org

[sky, 2016-11-04 23:30:44]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2473233005/#ps20001
(title: "super nitty nits")

[sky, 2016-11-04 23:30:51]

You made me laugh. Super nitty nits.

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
File ui/views/mus/desktop_window_tree_host_mus.cc (right):

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
ui/views/mus/desktop_window_tree_host_mus.cc:51: DCHECK(parent_);
On 2016/11/04 23:21:43, msw wrote:
> nit: seems unnecessary to DCHECK a non-null value that's just been
> static-casted, and is about to be dereferenced, but I'll leave it up to you.

Done.

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
ui/views/mus/desktop_window_tree_host_mus.cc:83: for (DesktopWindowTreeHostMus*
child : children_copy)
On 2016/11/04 23:21:43, msw wrote:
> totally optional nit: convert the corresponding DesktopWindowTreeHostX11 code
to
> better match this (member names, for-range loop, comments, etc.) or vice
versa.

I'm leaving that code alone.

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
ui/views/mus/desktop_window_tree_host_mus.cc:92:
native_widget_delegate_->OnNativeWidgetDestroying();
On 2016/11/04 23:21:43, msw wrote:
> q: DesktopWindowTreeHostX11 orders this before child/parent destruction, is
> there a reason they should differ?

Good catch. Updated.

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
File ui/views/mus/desktop_window_tree_host_mus.h (right):

https://codereview.chromium.org/2473233005/diff/1/ui/views/mus/desktop_window...
ui/views/mus/desktop_window_tree_host_mus.h:8: #include <memory>
On 2016/11/04 23:21:43, msw wrote:
> nit: #include <set>

Done.

[commit-bot: I haz the power, 2016-11-04 23:31:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 00:34:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-05 00:39:14]

Description was changed from

==========
Wires up transients for DesktopWindowTreeHostMus

This code is a copy of that in DesktopWindowTreeHostX11.

BUG=660994
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Wires up transients for DesktopWindowTreeHostMus

This code is a copy of that in DesktopWindowTreeHostX11.

BUG=660994
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/7cb222342ba74dc2241930b02739c10861d51dfe
Cr-Commit-Position: refs/heads/master@{#430090}
==========

[commit-bot: I haz the power, 2016-11-05 00:39:15]

Patchset 2 (id:??) landed as
https://crrev.com/7cb222342ba74dc2241930b02739c10861d51dfe
Cr-Commit-Position: refs/heads/master@{#430090}