Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2473233004: Implement FileState.hashCode/==. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement FileState.hashCode/==. Object.hashCode is still expensive, so this change makes recovering after a change about 7% faster. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0ff1d20bfd619017f9012e659c5f6892a9a7b05e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-04 19:09:51 UTC) #1
Paul Berry
lgtm
4 years, 1 month ago (2016-11-04 23:25:58 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 0ff1d20bfd619017f9012e659c5f6892a9a7b05e (presubmit successful).
4 years, 1 month ago (2016-11-04 23:55:45 UTC) #4
Brian Wilkerson
4 years, 1 month ago (2016-11-07 14:43:31 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698