Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(144)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/mjsunit/ignition/regress-662418.js
Issue
2473223004
:
[Interpreter] Ensure ValueOf is only called once for post-increment operations. (Closed)
Patch Set: Fix golden files
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
src/interpreter/bytecode-generator.cc
test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden
test/cctest/interpreter/bytecode_expectations/CountOperators.golden
test/cctest/interpreter/bytecode_expectations/GlobalCountOperators.golden
test/mjsunit/ignition/regress-662418.js
View unified diff
|
Download patch
« src/interpreter/bytecode-generator.cc
('K') |
« test/cctest/interpreter/bytecode_expectations/GlobalCountOperators.golden
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 the V8 project authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
var valueof_calls = 0;
6
7
var v = {
8
toString: function() {
9
var z = w++;
10
}
11
};
12
var w = {
13
valueOf: function() {
14
valueof_calls++;
15
}
16
};
17
var x = { [v]: 'B' };
18
assertTrue(valueof_calls == 1);
OLD
NEW
« src/interpreter/bytecode-generator.cc
('K') |
« test/cctest/interpreter/bytecode_expectations/GlobalCountOperators.golden
('k') |
no next file »
|
no next file with comments »
Issue 2473223004: [Interpreter] Ensure ValueOf is only called once for post-increment operations. (Closed)
Created 4 years, 1 month ago by rmcilroy
Modified 4 years, 1 month ago
Reviewers: mythria, Jarin
Base URL:
Comments: 1
This is Rietveld
408576698
Chromium Code Reviews
Issue 2473223004:
[Interpreter] Ensure ValueOf is only called once for post-increment operations. (Closed)
