Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2473223003: Do not duplicate constructors for named mixin applications. (Closed)

Created:
4 years, 1 month ago by asgerf
Modified:
4 years, 1 month ago
Reviewers:
jensj, Johnni Winther
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not duplicate constructors for named mixin applications. BUG= R=jensj@google.com Committed: https://github.com/dart-lang/kernel/commit/510a67f3165828843bdcd8e6ecff02ba10a871e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M lib/transformations/mixin_full_resolution.dart View 1 chunk +11 lines, -7 lines 0 comments Download
M testcases/spec-mode/redirecting_factory.baseline.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M testcases/strong-mode/redirecting_factory.baseline.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M testcases/type-propagation/redirecting_factory.baseline.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 1 month ago (2016-11-04 12:19:14 UTC) #2
jensj
lgtm
4 years, 1 month ago (2016-11-04 12:43:23 UTC) #3
asgerf
4 years, 1 month ago (2016-11-04 12:45:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
510a67f3165828843bdcd8e6ecff02ba10a871e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698