DBC: When calling DRT_OptimizeInvokedFunction, patch the stack to have a stub instead of the to-be-…

DBC: When calling DRT_OptimizeInvokedFunction, patch the stack to have a stub instead of the to-be-optimized function as the caller.

Fixes #27746

R=fschneider@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/3658a16e4742ba4a1a473ed5b3f7afd48cf93d1f

[rmacnak, 2016-11-03 23:38:51]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, zra@google.com

[rmacnak, 2016-11-03 23:38:51]

Tested by adding VerifyPointers to DRT_OptimizeInvokedFunction.

[Florian Schneider, 2016-11-04 08:35:45]

Lgtm

[zra, 2016-11-04 16:01:05]

lgtm

https://codereview.chromium.org/2473213002/diff/1/runtime/vm/simulator_dbc.cc
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2473213002/diff/1/runtime/vm/simulator_dbc.cc...
runtime/vm/simulator_dbc.cc:1446: const StubEntry* stub =
StubCode::OptimizeFunction_entry();
Is it okay for this to be *any* stub, or does it have to be this one. If it can
be any stub, we should fill in something here that will die in an obvious way.

https://codereview.chromium.org/2473213002/diff/1/runtime/vm/stub_code_dbc.cc
File runtime/vm/stub_code_dbc.cc (right):

https://codereview.chromium.org/2473213002/diff/1/runtime/vm/stub_code_dbc.cc...
runtime/vm/stub_code_dbc.cc:38: __ Trap();
Oh okay, great.

[rmacnak, 2016-11-04 16:50:27]

https://codereview.chromium.org/2473213002/diff/1/runtime/vm/simulator_dbc.cc
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2473213002/diff/1/runtime/vm/simulator_dbc.cc...
runtime/vm/simulator_dbc.cc:1446: const StubEntry* stub =
StubCode::OptimizeFunction_entry();
On 2016/11/04 16:01:05, zra wrote:
> Is it okay for this to be *any* stub, or does it have to be this one. If it
can
> be any stub, we should fill in something here that will die in an obvious way.

Right, any stub because we'll switch to the new optimized code after returning
from the runtime call.

[rmacnak, 2016-11-04 16:51:07]

Description was changed from

==========
DBC: When calling DRT_OptimizeInvokedFunction, patch the stack to have a stub
instead of the to-be-optimized function as the caller.

Fixes #27746
==========

to

==========
DBC: When calling DRT_OptimizeInvokedFunction, patch the stack to have a stub
instead of the to-be-optimized function as the caller.

Fixes #27746

R=fschneider@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3658a16e4742ba4a1a473ed5b3f7afd48cf93d1f
==========

[rmacnak, 2016-11-04 16:51:08]

Committed patchset #1 (id:1) manually as
3658a16e4742ba4a1a473ed5b3f7afd48cf93d1f (presubmit successful).