Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2473203002: IndexedDB: Remove m_contextStopped from ActiveDOMObjecs (Closed)

Created:
4 years, 1 month ago by jsbell
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Remove m_contextStopped from ActiveDOMObjecs m_contextStopped is equivalent to !getExecutionContext(). So this CL removes m_contextStopped. The only gotcha is that the context is cleared in the base class *after* contextDestroyed() is called, so the one place that checked it synchronously during the call - IDBTransaction - needed special attention. BUG=589507 Committed: https://crrev.com/e5f1e46d7079517f3845b2ce1205c948284631b9 Cr-Commit-Position: refs/heads/master@{#429952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -45 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 5 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 9 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 7 chunks +8 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
jsbell
This is basically just haraken@'s https://codereview.chromium.org/1745933002/ dusted off, with IDBTransaction tweaked slightly, to see if ...
4 years, 1 month ago (2016-11-03 23:29:01 UTC) #2
jsbell
haraken@ - please take a look?
4 years, 1 month ago (2016-11-04 16:07:52 UTC) #8
haraken
LGTM
4 years, 1 month ago (2016-11-04 16:16:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473203002/1
4 years, 1 month ago (2016-11-04 16:52:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 18:13:54 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 18:17:52 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5f1e46d7079517f3845b2ce1205c948284631b9
Cr-Commit-Position: refs/heads/master@{#429952}

Powered by Google App Engine
This is Rietveld 408576698