Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2473153005: Revert of Increase test coverage for Content:// urls (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Increase test coverage for Content:// urls (patchset #6 id:100001 of https://codereview.chromium.org/2476823002/ ) Reason for revert: Failures in UrlSchemeTest https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36968 Original issue's description: > Add test for verifying that iframe contents that are served from content urls cannot be accessed by parent page. > > BUG=659492 > > Committed: https://crrev.com/1ddb80fd8f7bcba05f993b678d858ca687b98870 > Cr-Commit-Position: refs/heads/master@{#430093} TBR=tedchoc@chromium.org,nick@chromium.org,sgurun@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659492 Committed: https://crrev.com/9827b0296317830eac3ad9920103822f57930525 Cr-Commit-Position: refs/heads/master@{#430147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -187 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/UrlSchemeTest.java View 7 chunks +20 lines, -108 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/TestContentProvider.java View 3 chunks +64 lines, -55 lines 0 comments Download
D chrome/test/data/android/page_with_iframe_as_content_url.html View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/android/simple_iframe.html View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mathieu
Created Revert of Increase test coverage for Content:// urls
4 years, 1 month ago (2016-11-05 04:00:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473153005/1
4 years, 1 month ago (2016-11-05 04:00:36 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/test/data/android/page_with_iframe_as_content_url.html: While running git rm chrome/test/data/android/page_with_iframe_as_content_url.html; fatal: pathspec 'chrome/test/data/android/page_with_iframe_as_content_url.html' did ...
4 years, 1 month ago (2016-11-05 04:02:25 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9827b0296317830eac3ad9920103822f57930525 Cr-Commit-Position: refs/heads/master@{#430147}
4 years, 1 month ago (2016-11-05 04:05:06 UTC) #7
sgurun-gerrit only
4 years, 1 month ago (2016-11-05 04:17:55 UTC) #8
Message was sent while issue was closed. 
On 2016/11/05 04:05:06, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/9827b0296317830eac3ad9920103822f57930525
> Cr-Commit-Position: refs/heads/master@{#430147}

that is weird. 6 tests seemed to fail:
C 1799.867s Main  [  FAILED  ] 6 tests, listed below:
C 1799.867s Main  [  FAILED  ]
org.chromium.chrome.browser.UrlSchemeTest#testContentUrlAccess
C 1799.867s Main  [  FAILED  ]
org.chromium.chrome.browser.UrlSchemeTest#testContentUrlIframeAccessFromContentUrl
C 1799.867s Main  [  FAILED  ]
org.chromium.chrome.browser.UrlSchemeTest#testContentUrlImageFromContentUrl
C 1799.867s Main  [  FAILED  ]
org.chromium.chrome.browser.payments.PaymentRequestIncompletePhoneTest#testEditIncompletePhoneAndCancel
C 1799.867s Main  [  FAILED  ]
org.chromium.chrome.browser.precache.PrecacheUMATest#testRecordUMA_NativeLibraryNotLoaded
C 1799.867s Main  [  FAILED  ]
org.chromium.chrome.browser.UrlSchemeTest#testContentProviderResourceRequestCount
(TIMEOUT)

2 of them has no relation at all.

Powered by Google App Engine
This is Rietveld 408576698