Move some compiler intrinsic #defines to base/.

ios/third_party/blink/src/html_tokenizer_adapter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_THIRD_PARTY_BLINK_SRC_TOKENIZER_ADAPTER_H_
 #define IOS_THIRD_PARTY_BLINK_SRC_TOKENIZER_ADAPTER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
+#include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/macros.h"
 
-#define ALWAYS_INLINE inline __attribute__((always_inline))

[rohitrao (ping after 24h), 2016/11/07 23:16:13]

Is this being changed from "inline __attribute__((always_inline))" to just
"inline"?

[palmer, 2016/11/07 23:29:51]

No, no change. compiler_specific.h says:

#if COMPILER_GCC && defined(NDEBUG)
#define ALWAYS_INLINE inline __attribute__((__always_inline__))
#elif COMPILER_MSVC && defined(NDEBUG)
#define ALWAYS_INLINE __forceinline
#else
#define ALWAYS_INLINE inline
#endif

build/build_config.h shows only those 2 compilers as normal, and COMPILER_GCC
defined if __GNUC__ is defined, so I am assuming that this covers Clang too.

[sdefresne, 2016/11/08 08:40:20]

Yeah, clang defines __GNUC__:

$  clang -dM -E - < /dev/null|grep GNUC
#define __GNUC_MINOR__ 2
#define __GNUC_PATCHLEVEL__ 1
#define __GNUC_STDC_INLINE__ 1
#define __GNUC__ 4

-
 #define DEFINE_STATIC_LOCAL_STRING(name, arguments)                       \
     static const WebCore::LChar* name = (const WebCore::LChar*)arguments; \
     static const size_t name##Length = (arraysize(arguments) - 1); \
     DCHECK(name##Length == strlen((const char*)name))
 
 #define WTF_MAKE_NONCOPYABLE(x) DISALLOW_COPY_AND_ASSIGN(x)
 
 #define ASSERT(x) DCHECK(x)
 #define ASSERT_NOT_REACHED NOTREACHED
 
@@ skipping 19 matching lines @@
   const int lowerCaseOffset = 0x20;
   return c + lowerCaseOffset;
 }
 
 inline UChar ByteSwap(UChar c) {
   return ((c & 0x00ff) << 8) | ((c & 0xff00) >> 8);
 }
 }
 
 #endif  // IOS_THIRD_PARTY_BLINK_SRC_TOKENIZER_ADAPTER_H_