Use alignas to force alignment.

Use alignas to force alignment.

Using alignas reduces code and platform specific macros.

Use alignas instead of std::aligned_storage because it is unimplemneted
in MSVC 2015.

Here is the bug from MS:
https://connect.microsoft.com/VisualStudio/feedback/details/1559873/std-aligned-storage-cannot-align-type-with-16-byte

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468243002
TBR=reed@google.com

Committed: https://skia.googlesource.com/skia/+/12ae597ef54c35e9c447f5f52ecbc153503e8b73

[herb_g, 2016-11-03 20:18:09]

Description was changed from

==========
Use alignas to force alignment.

Using alignas reduces code and platform specific macros.

Use alignas instead of std::aligned_storage because it is unimplemneted
in MSVC 2015.

Here is the bug from MS:
https://connect.microsoft.com/VisualStudio/feedback/details/1559873/std-align...

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468243002
TBR=reed@google.com
==========

to

==========
Use alignas to force alignment.

Using alignas reduces code and platform specific macros.

Use alignas instead of std::aligned_storage because it is unimplemneted
in MSVC 2015.

Here is the bug from MS:
https://connect.microsoft.com/VisualStudio/feedback/details/1559873/std-align...

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468243002
TBR=reed@google.com
==========

[herb_g, 2016-11-03 20:18:09]

herb@google.com changed reviewers:
+ mtklein@google.com

[herb_g, 2016-11-03 20:40:04]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 20:40:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[herb_g, 2016-11-03 20:41:10]

This is my second attempt to simplify this code. The strategy of using
aligned_storage is not supported by MSVC. This change uses alignas to align the
structures.

[commit-bot: I haz the power, 2016-11-03 20:42:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 20:42:25]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[mtklein_C, 2016-11-03 20:43:21]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-11-03 20:43:21]

That type is literally pointless if it can't go above 8 bytes... way to go MSVC.

[reed1, 2016-11-03 20:44:16]

since this just deletes code from a (pseudo) public header, I approve lgtm

[mtklein_C, 2016-11-03 20:47:36]

https://codereview.chromium.org/2473143002/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline.h (right):

https://codereview.chromium.org/2473143002/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:87: // This could be implemented using
std::aligned_storage, but MSVC does not implement this. Use the
This code is clearer and less reinterpret_cast-y than the version with
std::aligned_storage.  This is not a workaround.  It's the ideal implementation.

Let's remove this comment.

[herb_g, 2016-11-03 20:49:33]

Fix clang builds.

[herb_g, 2016-11-03 20:51:49]

Remove comment.

[herb_g, 2016-11-03 20:53:43]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 20:53:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[herb_g, 2016-11-03 20:56:39]

On 2016/11/03 20:43:21, mtklein_C wrote:
> That type is literally pointless if it can't go above 8 bytes... way to go
MSVC.

That comment in the bug is not right. max_align_t is not the maximum alignment
of the compiler. It is the value for alignment_of(long double).

[commit-bot: I haz the power, 2016-11-03 21:28:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:28:52]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-11-04 14:51:56]

Fixed clang builds, and removed comments.
PTAL

[mtklein_C, 2016-11-04 15:04:23]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-11-04 15:04:24]

lgtm

[mtklein_C, 2016-11-04 15:04:24]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2473143002/#ps40001
(title: "Remove comment.")

[commit-bot: I haz the power, 2016-11-04 15:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 15:41:03]

Description was changed from

==========
Use alignas to force alignment.

Using alignas reduces code and platform specific macros.

Use alignas instead of std::aligned_storage because it is unimplemneted
in MSVC 2015.

Here is the bug from MS:
https://connect.microsoft.com/VisualStudio/feedback/details/1559873/std-align...

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468243002
TBR=reed@google.com
==========

to

==========
Use alignas to force alignment.

Using alignas reduces code and platform specific macros.

Use alignas instead of std::aligned_storage because it is unimplemneted
in MSVC 2015.

Here is the bug from MS:
https://connect.microsoft.com/VisualStudio/feedback/details/1559873/std-align...

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468243002
TBR=reed@google.com

Committed:
https://skia.googlesource.com/skia/+/12ae597ef54c35e9c447f5f52ecbc153503e8b73
==========

[commit-bot: I haz the power, 2016-11-04 15:41:04]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/12ae597ef54c35e9c447f5f52ecbc153503e8b73