third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp - Issue 2473113002: Stop preloading scripts that have invalid type/language attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

Issue 2473113002: Stop preloading scripts that have invalid type/language attributes (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp ('K') | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp ('k') | third_party/WebKit/Source/core/html/parser/PreloadRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

index 1eb352eee68676dae629eb26b0f80330984aba21..00e50fe2679784ed3c4cbf4f11eb21708de00405 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

@@ -94,11 +94,6 @@ void HTMLResourcePreloader::preload(

("WebCore.PreloadDelayMs", 0, 2000, 20));

preloadDelayHistogram.count(duration);

- if (preload->scriptHasInvalidTypeOrLanguage()) {

- Deprecation::countDeprecation(m_document,

- UseCounter::ScriptInvalidTypeOrLanguage);

Charlie Harrison 2016/11/03 21:00:41 You'll need to remove the ScriptInvalidTypeOrLangu

- }

Resource* resource =

m_document->loader()->startPreload(preload->resourceType(), request);

if (resource && preload->resourceType() == Resource::CSSStyleSheet) {