Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/build/bots/scripts/test_runner.py

Issue 2473103006: Rename XCTests test main target and output. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/ios/rules.gni ('K') | « ios/build/bots/chromium.fyi/EarlGreyiOS.json ('k') | ios/build/tools/convert_gn_xcodeproj.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/build/bots/scripts/test_runner.py
diff --git a/ios/build/bots/scripts/test_runner.py b/ios/build/bots/scripts/test_runner.py
index 9e4818e3720435ad3b45a5ae1dd449b5de5e159f..d536da98b239f7417cd3fc029f0c9256e376f332 100644
--- a/ios/build/bots/scripts/test_runner.py
+++ b/ios/build/bots/scripts/test_runner.py
@@ -682,9 +682,9 @@ class DeviceTestRunner(TestRunner):
"""
env = super(DeviceTestRunner, self).get_launch_env()
if self.xctest_path:
- # e.g. ios_web_shell_test_host
- env['APP_TARGET_NAME'] = (
- os.path.splitext(os.path.basename(self.app_path))[0])
# e.g. ios_web_shell_test
- env['TEST_TARGET_NAME'] = env['APP_TARGET_NAME'].rsplit('_', 1)[0]
+ env['APP_TARGET_NAME'] = os.path.splitext(
+ os.path.basename(self.app_path))[0]
+ # e.g. ios_web_shell_test_module
+ env['TEST_TARGET_NAME'] = env['APP_TARGET_NAME'] + '_module'
return env
« build/config/ios/rules.gni ('K') | « ios/build/bots/chromium.fyi/EarlGreyiOS.json ('k') | ios/build/tools/convert_gn_xcodeproj.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698