Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2473103003: Revert: Only create widgets if really needed (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert: Only create widgets if really needed This CL reverts ef523dd36aea991084b8b934df846014a5c09c6f which causes issues with syncing of form fields over pages. The initial bug had follow on fixes which seem to have rendered this fix un-needed. BUG=chromium:632709, chromium:661294 Committed: https://pdfium.googlesource.com/pdfium/+/c5267c54ea32ade03bf10e6bb203e34e3fcbd77d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -44 lines) Patch
M fpdfsdk/cpdfsdk_interform.h View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 7 chunks +6 lines, -9 lines 0 comments Download
M fpdfsdk/javascript/Field.h View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 20 chunks +22 lines, -31 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
dsinclair
PTAL. I tested the testfocus.pdf, testfocus2.pdf and 632709_2.pdf files and non of them had ASAN ...
4 years, 1 month ago (2016-11-03 18:58:03 UTC) #2
Lei Zhang
It would be nice to understand what else fixed this.
4 years, 1 month ago (2016-11-03 21:17:20 UTC) #7
Lei Zhang
On 2016/11/03 21:17:20, Lei Zhang wrote: > It would be nice to understand what else ...
4 years, 1 month ago (2016-11-03 21:17:50 UTC) #9
Tom Sepez
What Lei said. RS LGTM otherwise.
4 years, 1 month ago (2016-11-03 22:37:48 UTC) #10
dsinclair
On 2016/11/03 21:17:50, Lei Zhang wrote: > On 2016/11/03 21:17:20, Lei Zhang wrote: > > ...
4 years, 1 month ago (2016-11-04 00:21:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473103003/1
4 years, 1 month ago (2016-11-04 22:20:23 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 22:35:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c5267c54ea32ade03bf10e6bb203e34e3fcb...

Powered by Google App Engine
This is Rietveld 408576698