Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2473093003: Fix up naming in CString. (Closed)

Created:
4 years, 1 month ago by esprehn
Modified:
4 years, 1 month ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix up naming in CString. CStringBuffer -> CStringImpl. newUninitialized -> createUninitialized. It now matches WTF::String for names. Committed: https://crrev.com/774b09e17405e3e5611c8bb7dc0b726be08fbd7a Cr-Commit-Position: refs/heads/master@{#429773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -49 lines) Patch
M third_party/WebKit/Source/platform/exported/WebCString.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LineEnding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.h View 3 chunks +13 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/CStringTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecLatin1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUserDefined.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/WebCString.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
esprehn
4 years, 1 month ago (2016-11-04 00:49:55 UTC) #4
haraken
LGTM
4 years, 1 month ago (2016-11-04 00:58:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473093003/1
4 years, 1 month ago (2016-11-04 01:00:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 02:45:14 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 02:48:04 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/774b09e17405e3e5611c8bb7dc0b726be08fbd7a
Cr-Commit-Position: refs/heads/master@{#429773}

Powered by Google App Engine
This is Rietveld 408576698