Improve GCM enum switch type safety

Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

Also converted two lists of == FOO || == BAR || == BAZ to switches
for the same reason.

And reordered a few switches to match the enums.

Should have no functional changes, except that GetConnectionResetReasonString can now stringify NEW_HEARTBEAT_INTERVAL (an enum value that had been omitted).

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2427633005
Cr-Commit-Position: refs/heads/master@{#426303}
(cherry picked from commit 133bfbad6055349368a955d16318c1997d39810b)

Committed: https://chromium.googlesource.com/chromium/src/+/f6af6a205a30cb5d3bc2f9682072c5df85b4660b

[johnme, 2016-11-03 17:45:38]

Description was changed from

==========
Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

Also converted two lists of == FOO || == BAR || == BAZ to switches
for the same reason.

And reordered a few switches to match the enums.

Should have no functional changes, except that GetConnectionResetReasonString
can now stringify NEW_HEARTBEAT_INTERVAL (an enum value that had been omitted).

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2427633005
Cr-Commit-Position: refs/heads/master@{#426303}
(cherry picked from commit 133bfbad6055349368a955d16318c1997d39810b)
==========

to

==========
Improve GCM enum switch type safety

Now that most/all of our compilers warn when enum values are omitted
from a switch statement with no default case, it's better to omit the
default case so that anyone adding new enum values gets compile
failures if they forget to update one of the switches.

Also converted two lists of == FOO || == BAR || == BAZ to switches
for the same reason.

And reordered a few switches to match the enums.

Should have no functional changes, except that GetConnectionResetReasonString
can now stringify NEW_HEARTBEAT_INTERVAL (an enum value that had been omitted).

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2427633005
Cr-Commit-Position: refs/heads/master@{#426303}
(cherry picked from commit 133bfbad6055349368a955d16318c1997d39810b)

Committed:
https://chromium.googlesource.com/chromium/src/+/f6af6a205a30cb5d3bc2f9682072...
==========

[johnme, 2016-11-03 17:45:40]

Committed patchset #1 (id:1) manually as
f6af6a205a30cb5d3bc2f9682072c5df85b4660b.