headless/public/internal/value_conversions.h - Issue 2473073003: [headless] Refactor headless devtools client API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/public/internal/value_conversions.h

Issue 2473073003: [headless] Refactor headless devtools client API. (Closed)

Patch Set: Address comments from skyostil@. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/public/internal/value_conversions.h

diff --git a/headless/public/internal/value_conversions.h b/headless/public/internal/value_conversions.h

index c25a0cd1ce22745342e3c4fb42fa2986be4199b4..4a85a02a464e1d1202ec7e7d37c9895943c96c1e 100644

--- a/headless/public/internal/value_conversions.h

+++ b/headless/public/internal/value_conversions.h

@@ -14,7 +14,7 @@ namespace headless {

namespace internal {

// Generic conversion from a type to a base::Value. Implemented in

-// type_conversions.h after all type-specific ToValueImpls have been defined.

+// types_DOMAIN.cc after all type-specific ToValueImpls have been defined.

template <typename T>

std::unique_ptr<base::Value> ToValue(const T& value);