Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2473073002: [heap] Print timestamp in memory reducer (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Print timestamp in memory reducer R=ulan@chromium.org BUG= Committed: https://crrev.com/9311bc119172d6f006d93d09d049776b9fed7fb3 Cr-Commit-Position: refs/heads/master@{#40756}

Patch Set 1 #

Patch Set 2 : More prints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M src/heap/memory-reducer.cc View 1 4 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Lippautz
4 years, 1 month ago (2016-11-03 17:06:46 UTC) #1
ulan
lgtm
4 years, 1 month ago (2016-11-04 09:48:50 UTC) #6
Michael Lippautz
On 2016/11/04 09:48:50, ulan wrote: > lgtm fyi: also changed the other print statements of ...
4 years, 1 month ago (2016-11-04 10:05:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473073002/20001
4 years, 1 month ago (2016-11-04 10:05:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 10:32:34 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9311bc119172d6f006d93d09d049776b9fed7fb3
Cr-Commit-Position: refs/heads/master@{#40756}

Powered by Google App Engine
This is Rietveld 408576698