Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2473023002: Remove self-DEPS from chrome/variations/DEPS. (Closed)

Created:
4 years, 1 month ago by gab
Modified:
4 years, 1 month ago
Reviewers:
jwd
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, asvitkine+watch_chromium.org, droger+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove self-DEPS from chrome/variations/DEPS. BUG=None Committed: https://crrev.com/e89fc14086f099160141dc92d8eb94a5c2dd0873 Cr-Commit-Position: refs/heads/master@{#430120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M components/variations/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
gab
Stumbled upon this, self-deps isn't required.
4 years, 1 month ago (2016-11-03 15:34:16 UTC) #2
gab
On 2016/11/03 15:34:16, gab wrote: > Stumbled upon this, self-deps isn't required. @jwd: friendly ping
4 years, 1 month ago (2016-11-04 16:18:00 UTC) #3
jwd
lgtm
4 years, 1 month ago (2016-11-04 21:39:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473023002/1
4 years, 1 month ago (2016-11-05 01:22:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 01:35:20 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e89fc14086f099160141dc92d8eb94a5c2dd0873 Cr-Commit-Position: refs/heads/master@{#430120}
4 years, 1 month ago (2016-11-05 01:37:44 UTC) #9
Mathieu
4 years, 1 month ago (2016-11-05 03:34:33 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2480873003/ by mathp@chromium.org.

The reason for reverting is: Broke checkdeps:

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/48559.

Powered by Google App Engine
This is Rietveld 408576698