Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2473013002: Use range-based for in toCompositorTransformOperations (Closed)

Created:
4 years, 1 month ago by fs
Modified:
4 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use range-based for in toCompositorTransformOperations Avoids the awkward-looking indexing expressions. Make casted operations const while at it. Committed: https://crrev.com/29c97d3d7915b0e3456a3f9611d31d4a76849d34 Cr-Commit-Position: refs/heads/master@{#430247}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use auto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -25 lines) Patch
M third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp View 1 4 chunks +18 lines, -25 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
fs
4 years, 1 month ago (2016-11-03 15:25:34 UTC) #4
Eric Willigers
lgtm
4 years, 1 month ago (2016-11-03 21:14:04 UTC) #8
loyso (OOO)
https://codereview.chromium.org/2473013002/diff/1/third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp File third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp (right): https://codereview.chromium.org/2473013002/diff/1/third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp#newcode54 third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp:54: static_cast<ScaleTransformOperation*>(operation.get()); We could use auto transform = static_cast<const ScaleTransformOperation*>(operation.get()); ...
4 years, 1 month ago (2016-11-03 22:53:24 UTC) #9
fs
https://codereview.chromium.org/2473013002/diff/1/third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp File third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp (right): https://codereview.chromium.org/2473013002/diff/1/third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp#newcode54 third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp:54: static_cast<ScaleTransformOperation*>(operation.get()); On 2016/11/03 at 22:53:24, loyso wrote: > We ...
4 years, 1 month ago (2016-11-04 10:05:34 UTC) #12
loyso (OOO)
LGTM.
4 years, 1 month ago (2016-11-06 23:20:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473013002/20001
4 years, 1 month ago (2016-11-07 09:12:27 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 10:52:34 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 10:55:03 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29c97d3d7915b0e3456a3f9611d31d4a76849d34
Cr-Commit-Position: refs/heads/master@{#430247}

Powered by Google App Engine
This is Rietveld 408576698