|
|
DescriptionUse range-based for in toCompositorTransformOperations
Avoids the awkward-looking indexing expressions. Make casted operations
const while at it.
Committed: https://crrev.com/29c97d3d7915b0e3456a3f9611d31d4a76849d34
Cr-Commit-Position: refs/heads/master@{#430247}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Use auto #Messages
Total messages: 21 (13 generated)
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fs@opera.com changed reviewers: + alancutter@chromium.org, loyso@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ericwilligers@chromium.org changed reviewers: + ericwilligers@chromium.org
lgtm
https://codereview.chromium.org/2473013002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp (right): https://codereview.chromium.org/2473013002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp:54: static_cast<ScaleTransformOperation*>(operation.get()); We could use auto transform = static_cast<const ScaleTransformOperation*>(operation.get()); here and elsewhere.
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2473013002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp (right): https://codereview.chromium.org/2473013002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/animation/AnimationTranslationUtil.cpp:54: static_cast<ScaleTransformOperation*>(operation.get()); On 2016/11/03 at 22:53:24, loyso wrote: > We could use > auto transform = static_cast<const ScaleTransformOperation*>(operation.get()); > here and elsewhere. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM.
The CQ bit was checked by fs@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from ericwilligers@chromium.org Link to the patchset: https://codereview.chromium.org/2473013002/#ps20001 (title: "Use auto")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use range-based for in toCompositorTransformOperations Avoids the awkward-looking indexing expressions. Make casted operations const while at it. ========== to ========== Use range-based for in toCompositorTransformOperations Avoids the awkward-looking indexing expressions. Make casted operations const while at it. Committed: https://crrev.com/29c97d3d7915b0e3456a3f9611d31d4a76849d34 Cr-Commit-Position: refs/heads/master@{#430247} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/29c97d3d7915b0e3456a3f9611d31d4a76849d34 Cr-Commit-Position: refs/heads/master@{#430247} |