Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2473003005: Add descriptions to GetActionResult enum class. (Closed)

Created:
4 years, 1 month ago by Yusuke Sato
Modified:
4 years, 1 month ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add descriptions to GetActionResult enum class. BUG=None TEST=try Committed: https://crrev.com/1d5a7928ea320af4bec2952d61d39cbd799bb972 Cr-Commit-Position: refs/heads/master@{#430307}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h View 1 chunk +12 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
Yusuke Sato
PTAL The enum class was not self-explanatory after all (see https://codereview.chromium.org/2476783002/diff/10001/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc ). Let me add ...
4 years, 1 month ago (2016-11-04 21:09:54 UTC) #4
djacobo_
LGTM https://codereview.chromium.org/2473003005/diff/1/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h File chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h (right): https://codereview.chromium.org/2473003005/diff/1/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h#newcode19 chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h:19: // An enum returned from GetAction function. This ...
4 years, 1 month ago (2016-11-04 21:16:39 UTC) #5
Luis Héctor Chávez
lgtm
4 years, 1 month ago (2016-11-07 16:56:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473003005/1
4 years, 1 month ago (2016-11-07 17:06:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 17:36:07 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 17:44:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d5a7928ea320af4bec2952d61d39cbd799bb972
Cr-Commit-Position: refs/heads/master@{#430307}

Powered by Google App Engine
This is Rietveld 408576698