Issue 2473001: - Continue removing [static] qualifier from methods on StubCache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2473001: - Continue removing [static] qualifier from methods on StubCache (Closed)

Created:
10 years, 6 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

- Continue removing [static] qualifier from methods on StubCache Committed: http://code.google.com/p/v8/source/detail?r=4776

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -16 lines)			Patch
M	src/debug.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/ic.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/isolate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/stub-cache.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/stub-cache.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/cctest/test-debug.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Vitaly Repeshko

10 years, 6 months ago (2010-06-01 21:42:39 UTC) #2

LGTM.

Please add "TODO(isolates)" comment to CALL_HEAP_FUNCTION so that we won't
forget about caching the isolate there.