Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tests/isolate/spawn_uri_negative_test.dart

Issue 24730002: Automatically append ".js" on spawnUri if we are running in JavaScript. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove todo. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/isolate/spawn_uri_negative_test.dart
diff --git a/tests/isolate/spawn_uri_negative_test.dart b/tests/isolate/spawn_uri_negative_test.dart
index 6e5be3beceb45f139183f4a5f215582801c78219..b744eeb40b0ece2a797af5bf2174eb504456ce64 100644
--- a/tests/isolate/spawn_uri_negative_test.dart
+++ b/tests/isolate/spawn_uri_negative_test.dart
@@ -18,8 +18,7 @@ main() {
port.close();
}));
- // TODO(eub): make this work for non-JS targets.
- SendPort s = spawnUri('spawn_uri_child_isolate.js');
+ SendPort s = spawnUri('spawn_uri_child_isolate.dart');
s.send('hi', port.toSendPort());
});
}

Powered by Google App Engine
This is Rietveld 408576698