Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 2472983003: Remove usage time.cc of CheckedNumeric::validity() (Closed)

Created:
2 years, 11 months ago by jschuh
Modified:
2 years, 11 months ago
Reviewers:
Tom Sepez, brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage time.cc of CheckedNumeric::validity() Fix the API abuse while preserving existing dubious behavior. BUG=613003 TBR=brettw@chromium.org Committed: https://crrev.com/428cf9473ad24fc6e026ebe8fe12f0181c9c35d4 Cr-Commit-Position: refs/heads/master@{#430018}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : wip #

Total comments: 2

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M base/time/time.h View 1 2 3 2 chunks +13 lines, -6 lines 0 comments Download
M base/time/time.cc View 1 2 1 chunk +12 lines, -16 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
jschuh
This is the correct one. tsepez@ - For checking the meat of the change. brettw@ ...
2 years, 11 months ago (2016-11-04 16:11:47 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/2472983003/diff/40001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/2472983003/diff/40001/base/time/time.h#newcode218 base/time/time.h:218: if ((delta_ < 0) ^ (a <= 0)) ...
2 years, 11 months ago (2016-11-04 16:58:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472983003/80001
2 years, 11 months ago (2016-11-04 17:13:38 UTC) #10
jschuh
https://codereview.chromium.org/2472983003/diff/40001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/2472983003/diff/40001/base/time/time.h#newcode218 base/time/time.h:218: if ((delta_ < 0) ^ (a <= 0)) On ...
2 years, 11 months ago (2016-11-04 17:14:07 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/256715) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
2 years, 11 months ago (2016-11-04 19:15:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472983003/80001
2 years, 11 months ago (2016-11-04 19:22:56 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:80001)
2 years, 11 months ago (2016-11-04 21:16:51 UTC) #17
commit-bot: I haz the power
2 years, 11 months ago (2016-11-04 21:20:48 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/428cf9473ad24fc6e026ebe8fe12f0181c9c35d4
Cr-Commit-Position: refs/heads/master@{#430018}

Powered by Google App Engine
This is Rietveld 408576698