Simplify Checked arithmetic functions in base/numerics

Simplify Checked arithmetic functions in base/numerics

Starting the process of restructuring to match the GCC and
Clang intrinsics. This step is mostly just replacing
RangeConstraint with bool.

BUG=613003
Committed: https://crrev.com/12d6cf3734f7f1cd64cf52812644a6a49b4da1fe
Cr-Commit-Position: refs/heads/master@{#430150}

[jschuh, 2016-11-04 16:09:55]

jschuh@chromium.org changed reviewers:
+ brettw@chromium.org, tsepez@chromium.org

[jschuh, 2016-11-04 16:09:55]

tsepez@ - For checking the meat of the change.
brettw@ - For base owners review.

[jschuh, 2016-11-04 16:10:35]

jschuh@chromium.org changed reviewers:
- brettw@chromium.org, tsepez@chromium.org

[jschuh, 2016-11-04 16:10:35]

Sorry, wrong change. Please ignore this WIP.

[jschuh, 2016-11-04 20:31:02]

Description was changed from

==========
Simplify Checked arthmetic functions in base/numerics

BUG=613003
==========

to

==========
Simplify Checked arithmetic functions in base/numerics

Mostly just replace RangeConstraint with bool.

BUG=613003
==========

[jschuh, 2016-11-04 20:32:47]

jschuh@chromium.org changed reviewers:
+ tsepez@chromium.org

[jschuh, 2016-11-04 20:32:48]

tsepez@ - Now it's ready for review. This part is mostly just mechanically
replacing the four-value enum with a bool, and simplifying the conditionals to
account for the unused state.

[Tom Sepez, 2016-11-04 20:46:50]

https://codereview.chromium.org/2472933003/diff/60001/base/numerics/safe_math...
File base/numerics/safe_math_impl.h (right):

https://codereview.chromium.org/2472933003/diff/60001/base/numerics/safe_math...
base/numerics/safe_math_impl.h:453: bool is_valid() const { return
isfinite(value_); }
is this std::isfinite() ?

[Tom Sepez, 2016-11-04 21:09:44]

LGTM otherwise.

[jschuh, 2016-11-04 21:41:07]

https://codereview.chromium.org/2472933003/diff/60001/base/numerics/safe_math...
File base/numerics/safe_math_impl.h (right):

https://codereview.chromium.org/2472933003/diff/60001/base/numerics/safe_math...
base/numerics/safe_math_impl.h:453: bool is_valid() const { return
isfinite(value_); }
On 2016/11/04 20:46:50, Tom Sepez wrote:
> is this std::isfinite() ?  

Done.

[jschuh, 2016-11-04 21:41:10]

The CQ bit was checked by jschuh@chromium.org

[jschuh, 2016-11-04 21:41:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2472933003/#ps80001
(title: "nit")

[commit-bot: I haz the power, 2016-11-04 21:42:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 21:55:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 21:55:30]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[brettw, 2016-11-04 22:04:53]

I don't understand the motivation for this change. I read the bug and understood
a bit more. Can you expand on this in the commit message?

[jschuh, 2016-11-04 23:52:33]

Description was changed from

==========
Simplify Checked arithmetic functions in base/numerics

Mostly just replace RangeConstraint with bool.

BUG=613003
==========

to

==========
Simplify Checked arithmetic functions in base/numerics

Starting the process of restructuring to match the GCC/Clang intrinsics. This
step is mostly replacing RangeConstraint with bool.

BUG=613003
==========

[jschuh, 2016-11-04 23:54:15]

Description was changed from

==========
Simplify Checked arithmetic functions in base/numerics

Starting the process of restructuring to match the GCC/Clang intrinsics. This
step is mostly replacing RangeConstraint with bool.

BUG=613003
==========

to

==========
Simplify Checked arithmetic functions in base/numerics

Starting the process of restructuring to match the GCC and
Clang intrinsics. This step is mostly just replacing
RangeConstraint with bool.

BUG=613003
==========

[jschuh, 2016-11-04 23:54:21]

The CQ bit was checked by jschuh@chromium.org

[jschuh, 2016-11-04 23:54:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2472933003/#ps100001
(title: "compiler warning fix")

[jschuh, 2016-11-04 23:54:44]

On 2016/11/04 22:04:53, brettw (ping on IM after 24h) wrote:
> I don't understand the motivation for this change. I read the bug and
understood
> a bit more. Can you expand on this in the commit message?

Updated with a bit more context.

[commit-bot: I haz the power, 2016-11-04 23:55:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 00:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 00:18:09]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[jschuh, 2016-11-05 02:24:55]

The CQ bit was checked by jschuh@chromium.org

[jschuh, 2016-11-05 02:24:55]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2472933003/#ps120001
(title: "typo")

[commit-bot: I haz the power, 2016-11-05 02:25:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 04:23:44]

Description was changed from

==========
Simplify Checked arithmetic functions in base/numerics

Starting the process of restructuring to match the GCC and
Clang intrinsics. This step is mostly just replacing
RangeConstraint with bool.

BUG=613003
==========

to

==========
Simplify Checked arithmetic functions in base/numerics

Starting the process of restructuring to match the GCC and
Clang intrinsics. This step is mostly just replacing
RangeConstraint with bool.

BUG=613003
==========

[commit-bot: I haz the power, 2016-11-05 04:23:46]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-05 04:27:48]

Description was changed from

==========
Simplify Checked arithmetic functions in base/numerics

Starting the process of restructuring to match the GCC and
Clang intrinsics. This step is mostly just replacing
RangeConstraint with bool.

BUG=613003
==========

to

==========
Simplify Checked arithmetic functions in base/numerics

Starting the process of restructuring to match the GCC and
Clang intrinsics. This step is mostly just replacing
RangeConstraint with bool.

BUG=613003

Committed: https://crrev.com/12d6cf3734f7f1cd64cf52812644a6a49b4da1fe
Cr-Commit-Position: refs/heads/master@{#430150}
==========

[commit-bot: I haz the power, 2016-11-05 04:27:49]

Patchset 7 (id:??) landed as
https://crrev.com/12d6cf3734f7f1cd64cf52812644a6a49b4da1fe
Cr-Commit-Position: refs/heads/master@{#430150}