Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js

Issue 2472913005: DevTools: Don't show an error in npm start when CHROMIUM_PATH is missing (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js
diff --git a/third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js b/third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js
index b163451f21b4546d6e82a7817ea662df298c1ebb..0a381f24ce1a146ec4fe2158e11c1bf746e17f0e 100644
--- a/third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js
+++ b/third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js
@@ -78,6 +78,9 @@ function launchChrome(filePath, chromeArgs, cleanup)
});
} catch (error) {
onLaunchChromeError();
+ if (cleanup)
+ cleanup();
+ return;
}
child.on("error", onLaunchChromeError);
child.on("exit", onExit);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698