Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2472913005: DevTools: Don't show an error in npm start when CHROMIUM_PATH is missing (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
chenwilliam, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't show an error in npm start when CHROMIUM_PATH is missing BUG=none Committed: https://crrev.com/fe64f860fd727cae179210713faee87b6c9e9209 Cr-Commit-Position: refs/heads/master@{#430136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
einbinder
ptal
4 years, 1 month ago (2016-11-04 21:37:37 UTC) #2
chenwilliam
lgtm
4 years, 1 month ago (2016-11-04 21:47:23 UTC) #3
dgozman
rs lgtm from committer
4 years, 1 month ago (2016-11-04 22:25:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472913005/1
4 years, 1 month ago (2016-11-05 01:57:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 03:09:06 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 03:11:17 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fe64f860fd727cae179210713faee87b6c9e9209
Cr-Commit-Position: refs/heads/master@{#430136}

Powered by Google App Engine
This is Rietveld 408576698