Add ScopedStubEnterpriseInstallAttributes for tests to set test install attributes.

chrome/browser/chromeos/policy/stub_enterprise_install_attributes.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h"
 
 #include <string>
 
+#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "components/policy/core/common/cloud/cloud_policy_constants.h"
 
 namespace policy {
 
 StubEnterpriseInstallAttributes::StubEnterpriseInstallAttributes()
     : EnterpriseInstallAttributes(NULL) {
   device_locked_ = true;
 }
 
 void StubEnterpriseInstallAttributes::SetDomain(const std::string& domain) {
   registration_domain_ = domain;
 }
 
 void StubEnterpriseInstallAttributes::SetRegistrationUser(
     const std::string& user) {
   registration_user_ = user;
 }
 
 void StubEnterpriseInstallAttributes::SetDeviceId(const std::string& id) {
   registration_device_id_ = id;
 }
 
 void StubEnterpriseInstallAttributes::SetMode(DeviceMode mode) {
   registration_mode_ = mode;
 }
 
+ScopedStubEnterpriseInstallAttributes::ScopedStubEnterpriseInstallAttributes(
+    const std::string& domain,
+    const std::string& registration_user,
+    const std::string& device_id,
+    DeviceMode mode) {
+  StubEnterpriseInstallAttributes* attributes =
+      new StubEnterpriseInstallAttributes();
+  attributes->SetDomain(domain);
+  attributes->SetRegistrationUser(registration_user);
+  attributes->SetDeviceId(device_id);
+  attributes->SetMode(mode);
+  BrowserPolicyConnectorChromeOS::SetInstallAttributesForTesting(attributes);

[Mattias Nissler (ping if slow), 2014/04/24 07:21:57]

Hm, the whole SetInstallAttributesForTesting seems to be broken after the
browser gets torn down. Have you tried what happens if you run 2 browser test
cases that call SetInstallAttributesForTesting with the --single_process flag?

If the only failure you see is due to SetInstallAttributesForTesting, it may
make sense to make a call to
BrowserPolicyConnectorChromeOS::SetInstallAttributesForTesting(NULL) in the
destructor (and change the DCHECK in the implementation to allow that). Or
alternatively, reset g_testing_install_attributes in the
BrowserPolicyConnectorChromeOS ctor after grabbing the reference.

[Steve Condie, 2014/04/24 18:14:28]

Good call, done. I was thinking that resetting g_testing_install_attributes
would not be useful since BrowserPolicyConnectorChromeOS only reads it when it's
initialized. However, since a new BrowserPolicyConnectorChromeOS is built for
each browser test within the same process we can set a new
g_testing_install_attributes each time.

+}
+
 }  // namespace policy