Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247283006: add polymer calculator pageset (Closed)

Created:
6 years, 8 months ago by ykyyip
Modified:
6 years, 8 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

add polymer calculator pageset BUG=333078 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266392

Patch Set 1 #

Patch Set 2 : forgot to add the actual pageset #

Patch Set 3 : enable sliding the panel too #

Patch Set 4 : add some linebreaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -3 lines) Patch
A + tools/perf/page_sets/data/polymer.json View 1 chunk +3 lines, -3 lines 0 comments Download
A tools/perf/page_sets/data/polymer_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/polymer.py View 1 2 3 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
ykyyip
Can you PTAL?
6 years, 8 months ago (2014-04-23 00:57:48 UTC) #1
adamk
lgtm, but these new python-based page sets are new to me.
6 years, 8 months ago (2014-04-23 01:03:06 UTC) #2
Dirk Pranke
We should all probably defer this review to Nat :). -- Dirk
6 years, 8 months ago (2014-04-23 02:24:34 UTC) #3
ykyyip
The CQ bit was checked by ykyyip@chromium.org
6 years, 8 months ago (2014-04-24 02:15:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ykyyip@chromium.org/247283006/40001
6 years, 8 months ago (2014-04-24 02:41:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 03:34:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 03:34:19 UTC) #7
ykyyip
nduca, tonyg, could you PTAL?
6 years, 8 months ago (2014-04-24 20:19:29 UTC) #8
ykyyip
6 years, 8 months ago (2014-04-25 18:59:56 UTC) #9
dtu
lgtm
6 years, 8 months ago (2014-04-25 22:31:08 UTC) #10
ykyyip
The CQ bit was checked by ykyyip@chromium.org
6 years, 8 months ago (2014-04-25 22:33:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ykyyip@chromium.org/247283006/60001
6 years, 8 months ago (2014-04-25 22:34:37 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 06:51:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 06:51:53 UTC) #14
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-26 13:20:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ykyyip@chromium.org/247283006/60001
6 years, 8 months ago (2014-04-26 13:21:33 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 22:41:46 UTC) #17
Message was sent while issue was closed. 
Change committed as 266392

Powered by Google App Engine
This is Rietveld 408576698