Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 247283003: HPACK: Implement delta encoding. (Closed)

Created:
6 years, 8 months ago by Johnny
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

HPACK: Implement delta encoding. HpackEncoder determines each header set's delta with the reference set, and makes use of the full HPACK encoding grammar to emit a minimal compression for the set. A "encode without compression" method has also been added which bypasses the dynamic table & Huffman coding. Selection of encoding method is controlled by SpdyFramer::enable_compression_. Encoding context updates are not yet used. That's a future optimization. HpackRoundTripTest has been added to verify that HpackEncoder & HpackDecoder successfully round-trip sequences of canned and dynamically generated header sets. This lands server change 65188922 by jgraettinger. BUG=339578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+860 lines, -99 lines) Patch
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/hpack_decoder_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_encoder.h View 4 chunks +50 lines, -7 lines 0 comments Download
M net/spdy/hpack_encoder.cc View 2 chunks +226 lines, -34 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 3 chunks +366 lines, -42 lines 0 comments Download
A net/spdy/hpack_round_trip_test.cc View 1 chunk +174 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 6 chunks +36 lines, -9 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Johnny
6 years, 8 months ago (2014-04-22 19:49:07 UTC) #1
Ryan Hamilton
6 years, 8 months ago (2014-04-22 20:30:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698