third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp - Issue 2472783002: Disable display list for 2D canvas when the canvas is color managed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 2472783002: Disable display list for 2D canvas when the canvas is color managed (Closed)

Patch Set: Setting the browser pixel test to Fail for now. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

index 9366ebfe73b95b24ce071896b444d2144c4c7587..f6c00754f645c41132bcd77ebcd31c2964d79630 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

@@ -857,6 +857,9 @@ class UnacceleratedSurfaceFactory

};

bool HTMLCanvasElement::shouldUseDisplayList(const IntSize& deviceSize) {

+ if (m_context->colorSpace() != CanvasColorSpace::kLegacyCanvasColorSpace)

Justin Novosad 2016/11/02 19:49:48 "CanvasColorSpace::" is not needed.

zakerinasab 2016/11/02 19:57:23 Done.

+ return false;

if (RuntimeEnabledFeatures::forceDisplayList2dCanvasEnabled())

return true;