Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2472783002: Disable display list for 2D canvas when the canvas is color managed (Closed)

Created:
4 years, 1 month ago by zakerinasab
Modified:
4 years, 1 month ago
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable display list for 2D canvas when the canvas is color managed For now display list is supported for 2D canvas only if the color space is legacy-srgb. If it is not, display list must be disabled. BUG=659251 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/c6ca4583cfe1d240959b65a42ea52c8afb515bdb Cr-Commit-Position: refs/heads/master@{#429419}

Patch Set 1 #

Patch Set 2 : Setting the browser pixel test to Fail for now. #

Total comments: 4

Patch Set 3 : Addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
zakerinasab
@kbr: We have to set the browser pixel tests to fail for now until we ...
4 years, 1 month ago (2016-11-02 19:49:19 UTC) #5
Justin Novosad
lgtm with nit https://codereview.chromium.org/2472783002/diff/20001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right): https://codereview.chromium.org/2472783002/diff/20001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp#newcode860 third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:860: if (m_context->colorSpace() != CanvasColorSpace::kLegacyCanvasColorSpace) "CanvasColorSpace::" is ...
4 years, 1 month ago (2016-11-02 19:49:48 UTC) #6
Justin Novosad
https://codereview.chromium.org/2472783002/diff/20001/content/test/gpu/gpu_tests/pixel_expectations.py File content/test/gpu/gpu_tests/pixel_expectations.py (left): https://codereview.chromium.org/2472783002/diff/20001/content/test/gpu/gpu_tests/pixel_expectations.py#oldcode22 content/test/gpu/gpu_tests/pixel_expectations.py:22: self.Skip('Pixel_CanvasDisplayLinearRGBUnaccelerated2D', ['android']) This skip can stay
4 years, 1 month ago (2016-11-02 19:50:37 UTC) #7
zakerinasab
New patch submitted. https://codereview.chromium.org/2472783002/diff/20001/content/test/gpu/gpu_tests/pixel_expectations.py File content/test/gpu/gpu_tests/pixel_expectations.py (left): https://codereview.chromium.org/2472783002/diff/20001/content/test/gpu/gpu_tests/pixel_expectations.py#oldcode22 content/test/gpu/gpu_tests/pixel_expectations.py:22: self.Skip('Pixel_CanvasDisplayLinearRGBUnaccelerated2D', ['android']) On 2016/11/02 19:50:37, Justin ...
4 years, 1 month ago (2016-11-02 19:57:24 UTC) #8
Ken Russell (switch to Gerrit)
lgtm
4 years, 1 month ago (2016-11-02 20:13:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472783002/40001
4 years, 1 month ago (2016-11-02 20:14:41 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-02 22:25:40 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 22:28:21 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c6ca4583cfe1d240959b65a42ea52c8afb515bdb
Cr-Commit-Position: refs/heads/master@{#429419}

Powered by Google App Engine
This is Rietveld 408576698