Disable display list for 2D canvas when the canvas is color managed

Disable display list for 2D canvas when the canvas is color managed

For now display list is supported for 2D canvas only if the color space
is legacy-srgb. If it is not, display list must be disabled.

BUG=659251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/c6ca4583cfe1d240959b65a42ea52c8afb515bdb
Cr-Commit-Position: refs/heads/master@{#429419}

[zakerinasab, 2016-11-02 19:33:53]

Description was changed from

==========
Disable display list for 2D canvas when the canvas is color managed

For now display list is supported for 2D canvas only if the color space
is legacy-srgb. If it is not, display list must be disabled.

BUG=659251
==========

to

==========
Disable display list for 2D canvas when the canvas is color managed

For now display list is supported for 2D canvas only if the color space
is legacy-srgb. If it is not, display list must be disabled.

BUG=659251
==========

[zakerinasab, 2016-11-02 19:33:54]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org, xidachen@chromium.org

[zakerinasab, 2016-11-02 19:47:30]

Description was changed from

==========
Disable display list for 2D canvas when the canvas is color managed

For now display list is supported for 2D canvas only if the color space
is legacy-srgb. If it is not, display list must be disabled.

BUG=659251
==========

to

==========
Disable display list for 2D canvas when the canvas is color managed

For now display list is supported for 2D canvas only if the color space
is legacy-srgb. If it is not, display list must be disabled.

BUG=659251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[zakerinasab, 2016-11-02 19:49:18]

zakerinasab@chromium.org changed reviewers:
+ kbr@chromium.org

[zakerinasab, 2016-11-02 19:49:19]

@kbr: We have to set the browser pixel tests to fail for now until we fix
crbug.com/659251 in another CL.

[Justin Novosad, 2016-11-02 19:49:48]

lgtm with nit

https://codereview.chromium.org/2472783002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2472783002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:860: if
(m_context->colorSpace() != CanvasColorSpace::kLegacyCanvasColorSpace)
"CanvasColorSpace::" is not needed.

[Justin Novosad, 2016-11-02 19:50:37]

https://codereview.chromium.org/2472783002/diff/20001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/pixel_expectations.py (left):

https://codereview.chromium.org/2472783002/diff/20001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/pixel_expectations.py:22:
self.Skip('Pixel_CanvasDisplayLinearRGBUnaccelerated2D', ['android'])
This skip can stay

[zakerinasab, 2016-11-02 19:57:24]

New patch submitted.

https://codereview.chromium.org/2472783002/diff/20001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/pixel_expectations.py (left):

https://codereview.chromium.org/2472783002/diff/20001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/pixel_expectations.py:22:
self.Skip('Pixel_CanvasDisplayLinearRGBUnaccelerated2D', ['android'])
On 2016/11/02 19:50:37, Justin Novosad wrote:
> This skip can stay

Done.

https://codereview.chromium.org/2472783002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2472783002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:860: if
(m_context->colorSpace() != CanvasColorSpace::kLegacyCanvasColorSpace)
On 2016/11/02 19:49:48, Justin Novosad wrote:
> "CanvasColorSpace::" is not needed.

Done.

[Ken Russell (switch to Gerrit), 2016-11-02 20:13:35]

lgtm

[zakerinasab, 2016-11-02 20:14:00]

The CQ bit was checked by zakerinasab@chromium.org

[zakerinasab, 2016-11-02 20:14:00]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2472783002/#ps40001
(title: "Addressing comments.")

[commit-bot: I haz the power, 2016-11-02 20:14:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 22:25:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-02 22:28:20]

Description was changed from

==========
Disable display list for 2D canvas when the canvas is color managed

For now display list is supported for 2D canvas only if the color space
is legacy-srgb. If it is not, display list must be disabled.

BUG=659251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Disable display list for 2D canvas when the canvas is color managed

For now display list is supported for 2D canvas only if the color space
is legacy-srgb. If it is not, display list must be disabled.

BUG=659251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/c6ca4583cfe1d240959b65a42ea52c8afb515bdb
Cr-Commit-Position: refs/heads/master@{#429419}
==========

[commit-bot: I haz the power, 2016-11-02 22:28:21]

Patchset 3 (id:??) landed as
https://crrev.com/c6ca4583cfe1d240959b65a42ea52c8afb515bdb
Cr-Commit-Position: refs/heads/master@{#429419}