Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2472773005: Remove autoplay-muted-videos feature flag. (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years, 1 month ago
Reviewers:
jam, DaleCurtis, dcheng
CC:
asvitkine+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove autoplay-muted-videos feature flag. Removes the flag and makes the Blink RuntimeEnabledFeature always on on Android. BUG=624570 Committed: https://crrev.com/03aabb73765c5e941207f61942a5959a997d2386 Cr-Commit-Position: refs/heads/master@{#432135}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove moar stuff #

Patch Set 3 : rebase #

Patch Set 4 : update java code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -49 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java View 1 2 3 5 chunks +5 lines, -26 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/web_preferences.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
mlamouri (slow - plz ping)
dcheng@, PTAL at: content/public/common/common_param_traits_macros.h jam@, PTAL at: chrome/browser/android/chrome_feature_list.cc content/browser/renderer_host/render_view_host_impl.cc content/child/runtime_features.cc content/public/common/content_features.h content/public/common/web_preferences.cc content/public/common/web_preferences.h content/renderer/render_view_impl.cc dalecurtis@, ...
4 years, 1 month ago (2016-11-04 16:17:59 UTC) #2
mlamouri (slow - plz ping)
https://codereview.chromium.org/2472773005/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (left): https://codereview.chromium.org/2472773005/diff/1/content/renderer/render_view_impl.cc#oldcode1149 content/renderer/render_view_impl.cc:1149: prefs.autoplay_muted_videos_enabled && !is_low_end_device); Note that autoplay muted is always ...
4 years, 1 month ago (2016-11-04 16:18:54 UTC) #5
dcheng
ipc rs lgtm
4 years, 1 month ago (2016-11-04 16:38:26 UTC) #6
jam
lgtm
4 years, 1 month ago (2016-11-04 17:26:20 UTC) #11
DaleCurtis
lgtm
4 years, 1 month ago (2016-11-04 19:42:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472773005/40001
4 years, 1 month ago (2016-11-15 00:02:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472773005/60001
4 years, 1 month ago (2016-11-15 07:00:31 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-15 07:04:32 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 07:07:47 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/03aabb73765c5e941207f61942a5959a997d2386
Cr-Commit-Position: refs/heads/master@{#432135}

Powered by Google App Engine
This is Rietveld 408576698