Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2472753002: Add Field Trial Testing Support to iOS (Closed)

Created:
4 years, 1 month ago by robliao
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), Alexei Svitkine (slow), gab, fdoray
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Field Trial Testing Support to iOS This brings desktop and Android default field trial testing support to iOS. Official builds, similar to desktop and Android, remain unaffected. As of this writing, the following variations are set by default with this change on iOS due to the field trial configuration: AutofillProfileCleanup:Enabled BrowserScheduler:Enabled PageRevisitInstrumentation:Enabled PasswordManagerSettingsMigration:Enable QUIC:Enabled TLS13Negotiation:Enabled TranslateRanker:EnforcementEnabled BUG=660554 Committed: https://crrev.com/4cdcaa90e9d83af4bd86cda475a16d3455766c48 Cr-Commit-Position: refs/heads/master@{#430347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 2 chunks +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (15 generated)
robliao
rohitrao: Please review this change. Thanks!
4 years, 1 month ago (2016-11-02 20:33:19 UTC) #6
Alexei Svitkine (slow)
lgtm
4 years, 1 month ago (2016-11-02 21:34:43 UTC) #8
rohitrao (ping after 24h)
lgtm Verified that the code was copied from chrome/browser/chrome_browser_main.cc.
4 years, 1 month ago (2016-11-07 19:04:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472753002/1
4 years, 1 month ago (2016-11-07 19:08:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472753002/1
4 years, 1 month ago (2016-11-07 19:26:58 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 19:36:10 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 19:46:41 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cdcaa90e9d83af4bd86cda475a16d3455766c48
Cr-Commit-Position: refs/heads/master@{#430347}

Powered by Google App Engine
This is Rietveld 408576698