Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2472743002: Make GetEncryptionKey thread-safe (Closed)

Created:
4 years, 1 month ago by jdoerrie
Modified:
4 years, 1 month ago
Reviewers:
cfroussios
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GetEncryptionKey thread-safe The current implementation of |GetEncryptionKey()| is thread-unsafe, resulting in a flaky unit test. This change fixes this issue by making the lock a |LazyInstance| instead of static. BUG=656926 R=cfroussios@chromium.org Committed: https://crrev.com/e9fc2e0c783274f4edd3adb175edf39d2ea8327b Cr-Commit-Position: refs/heads/master@{#429547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M components/os_crypt/os_crypt_mac.mm View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jdoerrie
4 years, 1 month ago (2016-11-02 18:33:12 UTC) #1
cfroussios
lgtm
4 years, 1 month ago (2016-11-03 09:02:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472743002/1
4 years, 1 month ago (2016-11-03 09:04:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-03 11:05:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472743002/1
4 years, 1 month ago (2016-11-03 11:38:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 12:49:24 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 12:54:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9fc2e0c783274f4edd3adb175edf39d2ea8327b
Cr-Commit-Position: refs/heads/master@{#429547}

Powered by Google App Engine
This is Rietveld 408576698