Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2472733002: Move ViewHostMsg_CreateFullscreenWidget to mojom. (Closed)

Created:
4 years, 1 month ago by Jay Civelli
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts the ViewHostMsg_CreateFullscreenWidget message to mojom. BUG=612500 TEST=The TestFlashFullscreen PPAPI test should pass. Committed: https://crrev.com/f7ebf972c7cb97ea2ba0900e7abd57879cc5285f Cr-Commit-Position: refs/heads/master@{#429923}

Patch Set 1 #

Patch Set 2 : Move ViewHostMsg_CreateFullscreenWidget to mojom. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 3 chunks +8 lines, -7 lines 0 comments Download
M content/common/render_message_filter.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Jay Civelli
4 years, 1 month ago (2016-11-02 22:10:20 UTC) #7
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-11-03 23:11:20 UTC) #8
Jay Civelli
Adding OWNERS reviewers: @dcheng could you review files under content/common? @jochen could you review files ...
4 years, 1 month ago (2016-11-03 23:22:55 UTC) #13
dcheng
mojo lgtm
4 years, 1 month ago (2016-11-04 04:16:55 UTC) #16
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-04 09:13:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472733002/20001
4 years, 1 month ago (2016-11-04 16:34:43 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 17:12:40 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 17:16:16 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7ebf972c7cb97ea2ba0900e7abd57879cc5285f
Cr-Commit-Position: refs/heads/master@{#429923}

Powered by Google App Engine
This is Rietveld 408576698