Issue 247273002: Collective fixes to types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247273002: Collective fixes to types (Closed)

Created:
6 years, 8 months ago by rossberg

Modified:
6 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.25

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+750 lines, -453 lines)			Patch
M	src/types.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/types.cc	View		5 chunks	+15 lines, -18 lines	0 comments	Download
M	test/cctest/test-types.cc	View	1	23 chunks	+734 lines, -434 lines	0 comments	Download

Total messages: 5 (0 generated)

rossberg

On 2014/04/22 11:11:45, Jakob wrote: > LGTM. How about some tests? Back-merged most of the ...

6 years, 8 months ago (2014-04-22 11:42:32 UTC) #3

Jakob Kummerow

Awesome. Rubberstamp LGTM for the tests (assuming they pass).

6 years, 8 months ago (2014-04-22 11:43:29 UTC) #4

rossberg

6 years, 8 months ago (2014-04-22 11:44:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20884 (presubmit successful).