Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2472723005: Make WebBluetooth chooser consistent on Android and desktops (Android part) (Closed)

Created:
4 years, 1 month ago by juncai
Modified:
4 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebBluetooth chooser consistent on Android and desktops (Android part) This CL makes the following changes: 1. Remove "Not seeing your device?" string. 2. Remove the period at "No Bluetooth devices found.", "No devices found." 3. Show get help link and scanning status text below the chooser: (a) When the Bluetooth is turned off, show "Get help" link text. (b) When scanning, show "Get help while scanning for devices...", the "Get help" is link text, "while scanning for devices..." is plain text. (c) When scanning and found some device, or scanning is complete, show "Get help or re-scan", both "Get help" and "re-scan" are link text. I uploaded some screenshots on the issue page. BUG=659271 Committed: https://crrev.com/5f17a6151a8d9d63087df4e0631e3e29b1414b7a Cr-Commit-Position: refs/heads/master@{#430055}

Patch Set 1 : make WebBluetooth chooser consistent on Android and desktops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
juncai
Please take a look.
4 years, 1 month ago (2016-11-04 01:10:26 UTC) #4
Ted C
lgtm
4 years, 1 month ago (2016-11-04 22:32:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472723005/1
4 years, 1 month ago (2016-11-04 22:52:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 23:05:16 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 23:07:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f17a6151a8d9d63087df4e0631e3e29b1414b7a
Cr-Commit-Position: refs/heads/master@{#430055}

Powered by Google App Engine
This is Rietveld 408576698