Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2472703002: MIPS[64]: Use immediate constants in Add, And, Or and Xor instructions in turbofan (Closed)

Created:
4 years, 1 month ago by ivica.bogosavljevic
Modified:
4 years, 1 month ago
Reviewers:
predrag.rudic, miran.karic, miran.karic
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Use immediate constants in Add, And, Or and Xor instructions in turbofan BUG= Committed: https://crrev.com/eaac3f0d5dc1c42d31b3b2e9ac8e6e22d5fecf6a Cr-Commit-Position: refs/heads/master@{#40732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -22 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 7 chunks +50 lines, -9 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 10 chunks +57 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ivica.bogosavljevic
PTAL
4 years, 1 month ago (2016-11-02 14:55:42 UTC) #2
miran.karic
lgtm
4 years, 1 month ago (2016-11-03 13:50:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472703002/1
4 years, 1 month ago (2016-11-03 15:14:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 15:42:28 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaac3f0d5dc1c42d31b3b2e9ac8e6e22d5fecf6a
Cr-Commit-Position: refs/heads/master@{#40732}

Powered by Google App Engine
This is Rietveld 408576698