[compiler] Sanitize IC counts for vector based ICs.

[compiler] Sanitize IC counts for vector based ICs.

All vector ICs use the TypeFeedbackVector::ComputeCounts method now,
while the remaining patching ICs still use the traditional way of
counting on the TypeFeedbackInfo hanging off the fullcodegen code
object. This fixes the problem that counts were sometimes off.

Drive-by-fix: Move FullCodeGenerator::CallIC to fullcodegen.cc.

R=yangguo@chromium.org

Committed: https://crrev.com/5ef1bddf80d176c3f882b699e65f48fba1af3da5
Cr-Commit-Position: refs/heads/master@{#40690}

[Benedikt Meurer, 2016-11-02 04:57:16]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 04:57:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-11-02 04:58:05]

Hey Yang,

Here's a simple fix for the IC counts.
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2016-11-02 05:00:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 05:00:30]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Yang, 2016-11-02 05:20:12]

lgtm

https://codereview.chromium.org/2472653002/diff/1/src/type-feedback-vector-inl.h
File src/type-feedback-vector-inl.h (right):

https://codereview.chromium.org/2472653002/diff/1/src/type-feedback-vector-in...
src/type-feedback-vector-inl.h:187: total++;
Can't we just compute total = gen + with at the end? The current way looks
brittle to breaking if someone adds another case and forgets.

[Benedikt Meurer, 2016-11-02 05:24:13]

https://codereview.chromium.org/2472653002/diff/1/src/type-feedback-vector-inl.h
File src/type-feedback-vector-inl.h (right):

https://codereview.chromium.org/2472653002/diff/1/src/type-feedback-vector-in...
src/type-feedback-vector-inl.h:187: total++;
No, because total is the total number of ICs, which also includes uninitialized
and polymorphic ICs.

[Benedikt Meurer, 2016-11-02 05:34:00]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 05:34:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-11-02 05:42:07]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-11-02 05:42:11]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-11-02 05:42:12]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2472653002/#ps20001
(title: "Fix compile.")

[commit-bot: I haz the power, 2016-11-02 05:42:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 06:00:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:18:54]

Description was changed from

==========
[compiler] Sanitize IC counts for vector based ICs.

All vector ICs use the TypeFeedbackVector::ComputeCounts method now,
while the remaining patching ICs still use the traditional way of
counting on the TypeFeedbackInfo hanging off the fullcodegen code
object. This fixes the problem that counts were sometimes off.

Drive-by-fix: Move FullCodeGenerator::CallIC to fullcodegen.cc.

R=yangguo@chromium.org
==========

to

==========
[compiler] Sanitize IC counts for vector based ICs.

All vector ICs use the TypeFeedbackVector::ComputeCounts method now,
while the remaining patching ICs still use the traditional way of
counting on the TypeFeedbackInfo hanging off the fullcodegen code
object. This fixes the problem that counts were sometimes off.

Drive-by-fix: Move FullCodeGenerator::CallIC to fullcodegen.cc.

R=yangguo@chromium.org

Committed: https://crrev.com/5ef1bddf80d176c3f882b699e65f48fba1af3da5
Cr-Commit-Position: refs/heads/master@{#40690}
==========

[commit-bot: I haz the power, 2016-11-17 22:18:57]

Patchset 2 (id:??) landed as
https://crrev.com/5ef1bddf80d176c3f882b699e65f48fba1af3da5
Cr-Commit-Position: refs/heads/master@{#40690}