chrome/browser/chromeos/extensions/file_manager/device_event_router.cc - Issue 2472643002: Suppress warnings on unplugging read-only removable devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/device_event_router.cc

Issue 2472643002: Suppress warnings on unplugging read-only removable devices. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/extensions/file_manager/device_event_router.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/device_event_router.cc b/chrome/browser/chromeos/extensions/file_manager/device_event_router.cc

index 2e65719d95fce6fa7f41f84841dbd9916d63a56c..b12bf26f9f9c7a40e919389ea8b4b1be37306521 100644

--- a/chrome/browser/chromeos/extensions/file_manager/device_event_router.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/device_event_router.cc

@@ -78,7 +78,7 @@ void DeviceEventRouter::OnDiskRemoved(

return;

const std::string& device_path = disk.system_path_prefix();

- if (!disk.mount_path().empty() &&

+ if (!disk.is_read_only() && !disk.mount_path().empty() &&

GetDeviceState(device_path) != DEVICE_HARD_UNPLUGGED_AND_REPORTED) {

OnDeviceEvent(file_manager_private::DEVICE_EVENT_TYPE_HARD_UNPLUGGED,

device_path);

« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/device_event_router_unittest.cc » ('j') | no next file with comments »