Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Issue 247263010: ServiceWorker: Wait for registration promise to resolve before changing states. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerContainer.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
index b691afde70a24a87424397a83edc457e967b655b..ef9d51411fd20d0dcac3970bc046077212d1bdbb 100644
--- a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
@@ -99,10 +99,10 @@ ScriptPromise ServiceWorkerContainer::registerServiceWorker(ExecutionContext* ex
class UndefinedValue {
public:
typedef WebServiceWorker WebType;
- static v8::Handle<v8::Value> from(NewScriptState* scriptState, WebServiceWorker* worker)
+ static v8::Handle<v8::Value> from(ScriptPromiseResolverWithContext* resolver, WebServiceWorker* worker)
yhirano 2014/04/24 01:53:49 If it's used in PromiseCallbackAdapter, I think we
falken 2014/04/24 02:38:42 Done. Much simpler.
{
ASSERT(!worker); // Anything passed here will be leaked.
- return v8::Undefined(scriptState->isolate());
+ return v8::Undefined(resolver->scriptState()->isolate());
}
private:

Powered by Google App Engine
This is Rietveld 408576698