Source/modules/serviceworkers/ServiceWorkerError.h - Issue 247263010: ServiceWorker: Wait for registration promise to resolve before changing states.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerError.h

Issue 247263010: ServiceWorker: Wait for registration promise to resolve before changing states. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: cleanup test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/serviceworkers/ServiceWorker.cpp ('K') | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | public/platform/WebServiceWorker.h » ('j') | public/platform/WebServiceWorkerProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerError.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerError.h b/Source/modules/serviceworkers/ServiceWorkerError.h

index 7f38f868e784613c7c802023bc7d4e3b0e3f794d..66ee2093bcbe4de60ad1e90ccbe0040b6a589542 100644

--- a/Source/modules/serviceworkers/ServiceWorkerError.h

+++ b/Source/modules/serviceworkers/ServiceWorkerError.h

@@ -38,13 +38,13 @@

namespace WebCore {

-class NewScriptState;

+class ScriptPromiseResolverWithContext;

class ServiceWorkerError {

public:

// For CallbackPromiseAdapter

typedef blink::WebServiceWorkerError WebType;

- static PassRefPtrWillBeRawPtr<DOMError> from(NewScriptState*, WebType* webErrorRaw)

+ static PassRefPtrWillBeRawPtr<DOMError> from(ScriptPromiseResolverWithContext*, WebType* webErrorRaw)

{

OwnPtr<WebType> webError = adoptPtr(webErrorRaw);

RefPtrWillBeRawPtr<DOMError> error = DOMError::create(errorString(webError->errorType), webError->message);