Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247263009: Rename jni_helper.h to jni_weak_ref.h. (Closed)

Created:
6 years, 8 months ago by newt (away)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, viettrungluu+watch_chromium.org, tburkard+watch_chromium.org, browser-components-watch_chromium.org, Ilya Sherman, tim+watch_chromium.org, cbentzel+watch_chromium.org, benquan, ben+mojo_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, haitaol+watch_chromium.org, gavinp+prer_chromium.org, Michael van Ouwerkerk, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, davidben+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Rename jni_helper.h to jni_weak_ref.h. BUG=365021 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -166 lines) Patch
M android_webview/native/android_protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_autofill_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_pdf_exporter.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_picture.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_quota_manager_bridge_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M base/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M base/android/jni_helper.h View 1 chunk +3 lines, -37 lines 0 comments Download
D base/android/jni_helper.cc View 1 chunk +0 lines, -67 lines 0 comments Download
A + base/android/jni_weak_ref.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + base/android/jni_weak_ref.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/banners/app_banner_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/bookmarks_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/dom_distiller/feedback_reporter_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/omnibox/omnibox_prerender.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/password_ui_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/password_ui_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/invalidation/invalidation_controller_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/android_profile_oauth2_token_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/infobar_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/infobar_container_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/translate_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/javascript_app_modal_dialog_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/navigation_popup.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.h View 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_interception/intercept_navigation_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_video_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_render_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/date_time_chooser_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/download_controller_android_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/interstitial_page_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/tracing_controller_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/web_contents_observer_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/location_api_adapter_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/power_save_blocker_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/ime_adapter_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/java/java_bound_object.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport_android.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/android/view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/android/view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/android/window_android.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/android/window_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
newt (away)
PTAL, thanks!
6 years, 8 months ago (2014-04-23 00:53:40 UTC) #1
Yaron
lgtm
6 years, 8 months ago (2014-04-23 01:00:50 UTC) #2
bulach
lgtm, thanks!
6 years, 8 months ago (2014-04-23 10:58:35 UTC) #3
mkosiba (inactive)
android_webview/ LGTM It's fine to TBR mechanical changes like these btw.
6 years, 8 months ago (2014-04-23 14:00:12 UTC) #4
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 8 months ago (2014-04-23 18:21:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/247263009/1
6 years, 8 months ago (2014-04-23 18:23:04 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 20:01:23 UTC) #7
Message was sent while issue was closed. 
Change committed as 265715

Powered by Google App Engine
This is Rietveld 408576698