Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/autofill/ios/browser/resources/autofill_controller.js

Issue 2472593005: Revert of [ios] Pass more --jscomp_error switches to the closure Compiler. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/ios/browser/resources/suggestion_controller.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/ios/browser/resources/autofill_controller.js
diff --git a/components/autofill/ios/browser/resources/autofill_controller.js b/components/autofill/ios/browser/resources/autofill_controller.js
index 743c033b8a71780ed549264cc1cce18e119afdae..510a9309cbd2137e5cb5afdb460135630327244d 100644
--- a/components/autofill/ios/browser/resources/autofill_controller.js
+++ b/components/autofill/ios/browser/resources/autofill_controller.js
@@ -2,19 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-/**
- * @fileoverview Installs Autofill management functions on the __gCrWeb object.
- *
- * It scans the DOM, extracting and storing forms and returns a JSON string
- * representing an array of objects, each of which represents an Autofill form
- * with information about a form to be filled and/or submitted and it can be
- * translated to struct FormData
- * (chromium/src/components/autofill/core/common/form_data.h) for further
- * processing.
-
- * TODO(crbug.com/647084): Enable checkTypes error for this file.
- * @suppress {checkTypes}
- */
+// Installs Autofill management functions on the |__gCrWeb| object.
+//
+// It scans the DOM, extracting and storing forms and returns a JSON string
+// representing an array of objects, each of which represents an Autofill form
+// with information about a form to be filled and/or submitted and it can be
+// translated to struct FormData
+// (chromium/src/components/autofill/core/common/form_data.h) for further
+// processing.
/** @typedef {HTMLInputElement|HTMLTextAreaElement|HTMLSelectElement} */
var FormControlElement;
@@ -55,12 +50,7 @@
* Namespace for this file. It depends on |__gCrWeb| having already been
* injected.
*/
-__gCrWeb.autofill = {};
-
-// Store autofill namespace object in a global __gCrWeb object referenced by a
-// string, so it does not get renamed by closure compiler during the
-// minification.
-__gCrWeb['autofill'] = __gCrWeb.autofill;
+__gCrWeb['autofill'] = {};
/**
* The maximum length allowed for form data.
« no previous file with comments | « no previous file | components/autofill/ios/browser/resources/suggestion_controller.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698