Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: ios/web/js_compile.gni

Issue 2472593005: Revert of [ios] Pass more --jscomp_error switches to the closure Compiler. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/util/java_action.gni") 5 import("//build/util/java_action.gni")
6 6
7 declare_args() { 7 declare_args() {
8 # Control whether the JavaScript files shipped with Chrome on iOS are 8 # Control whether the JavaScript files shipped with Chrome on iOS are
9 # compiled with closure_compiler or not. Useful for debugging. 9 # compiled with closure_compiler or not. Useful for debugging.
10 compile_javascript = true 10 compile_javascript = true
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 compile_js_target_name = target_name + "_compile_js" 106 compile_js_target_name = target_name + "_compile_js"
107 107
108 java_action_foreach(compile_js_target_name) { 108 java_action_foreach(compile_js_target_name) {
109 visibility = [ ":$_target_name" ] 109 visibility = [ ":$_target_name" ]
110 script = closure_compiler_path 110 script = closure_compiler_path
111 sources = invoker.sources 111 sources = invoker.sources
112 outputs = [ 112 outputs = [
113 "$target_gen_dir/{{source_file_part}}", 113 "$target_gen_dir/{{source_file_part}}",
114 ] 114 ]
115 115
116 # TODO(crbug.com/487804): need to enable the following compilation checks
117 # once the corresponding errors have been fixed:
118 # --jscomp_error=checkTypes
119 # --jscomp_error=checkVars
120 # --jscomp_error=missingProperties
121 # --jscomp_error=undefinedVars
116 args = [ 122 args = [
117 "--compilation_level", 123 "--compilation_level",
118 "SIMPLE_OPTIMIZATIONS", 124 "SIMPLE_OPTIMIZATIONS",
119 "--jscomp_error=checkTypes",
120 "--jscomp_error=checkVars",
121 "--jscomp_error=missingProperties",
122 "--jscomp_error=undefinedVars",
123 "--jscomp_error=accessControls", 125 "--jscomp_error=accessControls",
124 "--jscomp_error=ambiguousFunctionDecl", 126 "--jscomp_error=ambiguousFunctionDecl",
125 "--jscomp_error=constantProperty", 127 "--jscomp_error=constantProperty",
126 "--jscomp_error=deprecated", 128 "--jscomp_error=deprecated",
127 "--jscomp_error=externsValidation", 129 "--jscomp_error=externsValidation",
128 "--jscomp_error=globalThis", 130 "--jscomp_error=globalThis",
129 "--jscomp_error=invalidCasts", 131 "--jscomp_error=invalidCasts",
130 "--jscomp_error=missingReturn", 132 "--jscomp_error=missingReturn",
131 "--jscomp_error=nonStandardJsDocs", 133 "--jscomp_error=nonStandardJsDocs",
132 "--jscomp_error=suspiciousCode", 134 "--jscomp_error=suspiciousCode",
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 "visibility", 264 "visibility",
263 ]) 265 ])
264 266
265 sources = invoker.sources 267 sources = invoker.sources
266 outputs = [ 268 outputs = [
267 "{{bundle_resources_dir}}/{{source_file_part}}", 269 "{{bundle_resources_dir}}/{{source_file_part}}",
268 ] 270 ]
269 } 271 }
270 } 272 }
271 } 273 }
OLDNEW
« no previous file with comments | « components/translate/ios/browser/resources/translate_ios.js ('k') | ios/web/web_state/js/resources/base.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698