Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2472593004:
Reenable media-device enumeration integration test. (Closed)
|
Created:
4 years, 1 month ago by Guido Urdaneta Modified:
4 years, 1 month ago CC:
chromium-reviews, feature-media-reviews_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReenable media-device enumeration integration test.
Updated to use enumerateDevices and remove references to
MediaStreamTrack.getSources().
BUG=388194
Committed: https://crrev.com/eae01dae1bee162c20ee9e21b6b542603b346cd3
Cr-Commit-Position: refs/heads/master@{#430240}
Patch Set 1 #Patch Set 2 : fix handling of fake output devices and remove obsolete comments. #Patch Set 3 : rebase #
Messages
Total messages: 28 (18 generated)
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reenable media-device enumeration integration test. Updated to use enumerateDevices and remove references to MediaStreamTrack.getSources(). BUG=388194 ========== to ========== Reenable media-device enumeration integration test. Updated to use enumerateDevices and remove references to MediaStreamTrack.getSources(). BUG=388194 ==========
guidou@chromium.org changed reviewers: + hbos@chromium.org
Hi, PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
guidou@chromium.org changed reviewers: + phoglund@chromium.org
phoglund@chromium.org: PTAL
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by guidou@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hbos@chromium.org Link to the patchset: https://codereview.chromium.org/2472593004/#ps20001 (title: "fix handling of fake output devices and remove obsolete comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
The CQ bit was checked by guidou@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@chromium.org, hbos@chromium.org Link to the patchset: https://codereview.chromium.org/2472593004/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reenable media-device enumeration integration test. Updated to use enumerateDevices and remove references to MediaStreamTrack.getSources(). BUG=388194 ========== to ========== Reenable media-device enumeration integration test. Updated to use enumerateDevices and remove references to MediaStreamTrack.getSources(). BUG=388194 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reenable media-device enumeration integration test. Updated to use enumerateDevices and remove references to MediaStreamTrack.getSources(). BUG=388194 ========== to ========== Reenable media-device enumeration integration test. Updated to use enumerateDevices and remove references to MediaStreamTrack.getSources(). BUG=388194 Committed: https://crrev.com/eae01dae1bee162c20ee9e21b6b542603b346cd3 Cr-Commit-Position: refs/heads/master@{#430240} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/eae01dae1bee162c20ee9e21b6b542603b346cd3 Cr-Commit-Position: refs/heads/master@{#430240}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2487943002/ by guidou@chromium.org. The reason for reverting is: Temporary revert due to another CL prior to this one breaking some perf tests. See crbug.com/662414. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
