Navigation Timing Level 2

third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h

Index: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
index 7723329ec3732903820b88eeb3c31efede15dea3..c6e6bfc385dc9c10ead69fb09f91a71d18f75b3f 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h
@@ -41,10 +41,11 @@ namespace blink {
 class ResourceLoadTiming;
 class ResourceTimingInfo;
 
-class PerformanceResourceTiming final : public PerformanceEntry {
+class CORE_EXPORT PerformanceResourceTiming : public PerformanceEntry {
   DEFINE_WRAPPERTYPEINFO();
 
  public:
+  ~PerformanceResourceTiming() override;
   static PerformanceResourceTiming* create(const ResourceTimingInfo& info,
                                            double timeOrigin,
                                            double startTime,
@@ -67,9 +68,9 @@ class PerformanceResourceTiming final : public PerformanceEntry {
   AtomicString initiatorType() const;
 
   double workerStart() const;
-  double redirectStart() const;
-  double redirectEnd() const;
-  double fetchStart() const;
+  virtual double redirectStart() const;
+  virtual double redirectEnd() const;
+  virtual double fetchStart() const;
   double domainLookupStart() const;
   double domainLookupEnd() const;
   double connectStart() const;
@@ -77,7 +78,7 @@ class PerformanceResourceTiming final : public PerformanceEntry {
   double secureConnectionStart() const;
   double requestStart() const;
   double responseStart() const;
-  double responseEnd() const;
+  virtual double responseEnd() const;
   unsigned long long transferSize() const;
   unsigned long long encodedBodySize() const;
   unsigned long long decodedBodySize() const;
@@ -85,6 +86,21 @@ class PerformanceResourceTiming final : public PerformanceEntry {
  protected:
   void buildJSONValue(V8ObjectBuilder&) const override;
 
+  PerformanceResourceTiming(const AtomicString& initiatorType,
+                            double timeOrigin,
+                            ResourceLoadTiming*,
+                            double lastRedirectEndTime,
+                            double finishTime,
+                            unsigned long long transferSize,
+                            unsigned long long encodedBodyLength,
+                            unsigned long long decodedBodyLength,
+                            bool didReuseConnection,
+                            bool allowTimingDetails,
+                            bool allowRedirectDetails,

[Yoav Weiss, 2016/11/12 17:13:48]

Can these booleans be enums to avoid the "true /* explanation */" pattern?

[sunjian, 2016/11/14 22:12:28]

Added a TODO in the previous related comment.

+                            const String& name,
+                            const String& entryType,
+                            double startTime);
+
  private:
   PerformanceResourceTiming(const ResourceTimingInfo&,
                             double timeOrigin,
@@ -92,7 +108,6 @@ class PerformanceResourceTiming final : public PerformanceEntry {
                             double lastRedirectEndTime,
                             bool m_allowTimingDetails,
                             bool m_allowRedirectDetails);
-  ~PerformanceResourceTiming() override;
 
   double workerReady() const;