Navigation Timing Level 2

third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 31 matching lines @@
 // TODO(majidvp): Should return DOMHighResTimeStamp type instead
 static double monotonicTimeToDOMHighResTimeStamp(double timeOrigin,
                                                  double seconds) {
   ASSERT(seconds >= 0.0);
   if (!seconds || !timeOrigin)
     return 0.0;
   return PerformanceBase::clampTimeResolution(seconds - timeOrigin) * 1000.0;
 }
 
 PerformanceResourceTiming::PerformanceResourceTiming(
+    const AtomicString& initiatorType,
+    double timeOrigin,
+    ResourceLoadTiming* timing,
+    double lastRedirectEndTime,
+    double finishTime,
+    unsigned long long transferSize,
+    unsigned long long encodedBodyLength,
+    unsigned long long decodedBodyLength,
+    bool didReuseConnection,
+    bool allowTimingDetails,
+    bool allowRedirectDetails,
+    const String& name,
+    const String& entryType,
+    double startTime)

[kinuko, 2016/11/06 15:16:43]

Could we use delegated constructors to reduce duplicated code/initialization?

[sunjian, 2016/11/08 02:10:19]

Done.

+    : PerformanceEntry(
+          name,
+          entryType,
+          monotonicTimeToDOMHighResTimeStamp(timeOrigin, startTime),
+          monotonicTimeToDOMHighResTimeStamp(timeOrigin, finishTime)),
+      m_initiatorType(initiatorType),
+      m_timeOrigin(timeOrigin),
+      m_timing(timing),
+      m_lastRedirectEndTime(lastRedirectEndTime),
+      m_finishTime(finishTime),
+      m_transferSize(transferSize),
+      m_encodedBodySize(encodedBodyLength),
+      m_decodedBodySize(decodedBodyLength),
+      m_didReuseConnection(didReuseConnection),
+      m_allowTimingDetails(allowTimingDetails),
+      m_allowRedirectDetails(allowRedirectDetails) {}
+
+PerformanceResourceTiming::PerformanceResourceTiming(
     const ResourceTimingInfo& info,
     double timeOrigin,
     double startTime,
     double lastRedirectEndTime,
     bool allowTimingDetails,
     bool allowRedirectDetails)
     : PerformanceEntry(
           info.initialURL().getString(),
           "resource",
           monotonicTimeToDOMHighResTimeStamp(timeOrigin, startTime),
@@ skipping 191 matching lines @@
   builder.addNumber("secureConnectionStart", secureConnectionStart());
   builder.addNumber("requestStart", requestStart());
   builder.addNumber("responseStart", responseStart());
   builder.addNumber("responseEnd", responseEnd());
   builder.addNumber("transferSize", transferSize());
   builder.addNumber("encodedBodySize", encodedBodySize());
   builder.addNumber("decodedBodySize", decodedBodySize());
 }
 
 }  // namespace blink