Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 2472573004: Reland "Create internal fields on global proxy objects" (Closed)

Created:
4 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
4 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Create internal fields on global proxy objects" Original CL description: > Create internal fields on global proxy objects > > BUG=v8:5588 > R=verwaest@chromium.org BUG=v8:5588 TBR=verwaest@chromium.org Committed: https://crrev.com/bf77741d43eb36770cb340754649f0f54a602436 Cr-Commit-Position: refs/heads/master@{#40705}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M include/v8.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/api-natives.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
4 years, 1 month ago (2016-11-02 13:54:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472573004/1
4 years, 1 month ago (2016-11-02 13:55:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472573004/20001
4 years, 1 month ago (2016-11-02 14:11:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 14:40:02 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf77741d43eb36770cb340754649f0f54a602436
Cr-Commit-Position: refs/heads/master@{#40705}

Powered by Google App Engine
This is Rietveld 408576698