Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2472573003: [heap] Fix Unmapper::TearDown to include delayed chunks (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix Unmapper::TearDown to include delayed chunks Delayed chunks in the unmapper are chunks that should be unmapped but could potentially still be accessed by the sweeper (page header), hence their unmapping is delayed. During TearDown, however, we need to properly unmap those pages, i.e., check that they can now be unmapped (should always hold) and properly unmap them. BUG=chromium:656537 R=ulan@chromium.org Committed: https://crrev.com/588641f242f4adf5240ca02d95c945afa40ab6c9 Cr-Commit-Position: refs/heads/master@{#40698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/heap/spaces.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Lippautz
4 years, 1 month ago (2016-11-02 12:21:28 UTC) #1
ulan
lgtm
4 years, 1 month ago (2016-11-02 12:26:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472573003/1
4 years, 1 month ago (2016-11-02 13:08:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 13:10:26 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/588641f242f4adf5240ca02d95c945afa40ab6c9
Cr-Commit-Position: refs/heads/master@{#40698}

Powered by Google App Engine
This is Rietveld 408576698