Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 2472573002: Move MapCoordinatesMode and MapCoordinatesFlags to a separate header. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MapCoordinatesMode and MapCoordinatesFlags to a separate header. This way, LayoutGeometryMap.h doesn't need to include LayoutObject.h Committed: https://crrev.com/f31c8b51a1d5e1ac6f1ebdd7b855f78219c7c36b Cr-Commit-Position: refs/heads/master@{#429294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -22 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +1 line, -21 lines 0 comments Download
A third_party/WebKit/Source/core/layout/MapCoordinatesFlags.h View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-11-02 08:55:52 UTC) #6
Xianzhu
lgtm
4 years, 1 month ago (2016-11-02 16:12:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472573002/1
4 years, 1 month ago (2016-11-02 16:13:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 16:18:42 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 16:20:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f31c8b51a1d5e1ac6f1ebdd7b855f78219c7c36b
Cr-Commit-Position: refs/heads/master@{#429294}

Powered by Google App Engine
This is Rietveld 408576698